search

hawkular / hawkular-android-client

Apache License 2.0
10 stars 26 forks source link

Icon in explorer activity fixed #185

Closed anant-dev closed 7 years ago

anant-dev commented 7 years ago

Fixed Issue #180 Please review Updated screen - screenshot_2017-03-22-08-55-24-516

KeenWarrior commented 7 years ago

@anant-dev Would love to see svg files instead

anant-dev commented 7 years ago

@garg-anuj ok i ll replace them by svg files

anant-dev commented 7 years ago

@garg-anuj Done please review

KeenWarrior commented 7 years ago

You will need to execute : mvn license:format

anant-dev commented 7 years ago

@garg-anuj done for issue #180
and also resolved issue #187 by 5ed52795aef3f8092171f2e214dc261305b80a7f commit. Please review

m-murad commented 7 years ago

@anant-dev You have to to squash the commits before your PR is considered. Also you shouldn't solve multiple issues in one PR. I did it earlier and was asked to update the PR. If you are solving two issues send two PRs.

Regards

KeenWarrior commented 7 years ago

@anant-dev Please try not to solve more than one issue in one PR if they are not very much related