fixed app crash on adding a metric to favourite #186

hawkular / hawkular-android-client

Apache License 2.0

10 stars 26 forks source link

fixed app crash on adding a metric to favourite #186 #187

Closed pg301 closed 7 years ago

KeenWarrior commented 7 years ago

@pg301 You can borrow the work @anant-dev and complete this PR.

Refactor list_item_alert into list_item_with_menu
Provide it in FavMetricsAdapter.java

KeenWarrior commented 7 years ago

@pg301 you will need to rebase

KeenWarrior commented 7 years ago

@pg301 Rebasing this branch will need more effort than work in PR. You can either reset this branch with current master and work on that to resolve this issue. Or altogether create a new branch of master

pg301 commented 7 years ago

@garg-anuj Is it ok if I make a new new PR for this issue and close the current PR.

KeenWarrior commented 7 years ago

@pg301 Sure

pg301 commented 7 years ago

I am closing this PR since I have made a new PR addressing this issue.