search

hawkular / hawkular-android-client

Apache License 2.0
10 stars 26 forks source link

Search implemented in fragments. #194

Closed m-murad closed 7 years ago

m-murad commented 7 years ago

Fixes issue #173

@garg-anuj Sorry for being so late. To solve this I had to solve #186

Please merge if I'm allowed to do that.

pilhuhn commented 7 years ago

@free4murad Can you add some screenshots please?

m-murad commented 7 years ago

@pilhuhn Sure Let me upload a video instead so that things are more clear. https://drive.google.com/open?id=0ByRo_SG_Si40LWZ3Um55cmlpMms

m-murad commented 7 years ago

Metrics original - metrics-original Metrics search - metrics-search

Fav Triggers original fav-triggers-original Fav triggers search fav-triggers-search

Triggers original triggers-original Triggers search triggers-search

Alerts original alerts-original Alerts search alerts-search

KeenWarrior commented 7 years ago

@free4murad Great work. Nice but big PR. Could break in changing basic UI first and other work in later stages. Will need some time to review this big one

m-murad commented 7 years ago

Should I break the PR into two parts

  1. UI changes

  2. Implementing search functionality

    or is it fine like this?

KeenWarrior commented 7 years ago

@free4murad If you break then that will be much better

m-murad commented 7 years ago

@garg-anuj Should I send multiple PRs or single PR with multiple commits

KeenWarrior commented 7 years ago

@free4murad multiple PRs will be good idea