search

hawkular / hawkular-android-client

Apache License 2.0
10 stars 26 forks source link

App crashes in API versions 19 and below #214

Closed pg301 closed 7 years ago

pg301 commented 7 years ago

Here's the log: https://paste.ubuntu.com/24405633/

Demo: app crash

I think I know the fix, can I send a PR for this @garg-anuj

KeenWarrior commented 7 years ago

go on

KeenWarrior commented 7 years ago

If this is related to login activity. Better send PR to fork of @danielpassos

m-murad commented 7 years ago

@pg301

In activity_login.xml you need to replace android:src="@drawable/hawkular_logo" with app:srcCompat="@drawable/hawkular_logo".

The error is because we are using vector drawables instead of conventional PNG files. Why don't you check the whole project for this type of errors.

m-murad commented 7 years ago

The same error can be found in

  1. fragment_trigger_detail.xml - Line 37
pg301 commented 7 years ago

@free4murad Thanks for the suggestion. I knew the error, I was just scanning the layouts for similar errors. @garg-anuj since this is not connected to the login acitvity, I will send a PR here only?

m-murad commented 7 years ago

@pg301 Send one PR to @danielpassos branch and one to the main repo. In my opinion that will be a better think to do. But confirm with @garg-anuj before you proceed.