search

hawkular / hawkular-android-client

Apache License 2.0
10 stars 26 forks source link

Change in trigger identification for resources #52

Closed openwarrior closed 8 years ago

openwarrior commented 8 years ago

Trigger ID can now be independent of resource ID. So using the tag to identify it.

lucasponce commented 8 years ago

PR looks good to me Perhaps one side question is why don't use the hawkular-alerts-api package as base of the org.hawkular.client.android.backend.model package. There you have the tools for dealing with the json -> object serialization of alerts and it could save some of the work done here. Perhaps you can extend them in a class where you can implement the Parcel interface if needed.

openwarrior commented 8 years ago

@lucasponce I will surely look at that :)

pilhuhn commented 8 years ago

Thanks @anuj1708 :clap: