Added alerts api support

hawkular / hawkular-client-java

Java client for Hawkular

Apache License 2.0

11 stars 8 forks source link

Closed jkandasa closed 9 years ago

jkandasa commented 9 years ago

@vnugent I have added alerts api support. Kindly review and merge it

jkandasa commented 9 years ago

Ticket: Add support for Alert API #15

jkandasa commented 9 years ago

@vnugent Does Hawkular Demo server update to date?

FilipB commented 9 years ago

Just a few general comments:

some javadoc and comments would be definitely nice
is there any reason not to log anything?
not sure if this is doable everywhere but it's recommended to fix the code rather than using SuppressWarnings("unchecked")

jkandasa commented 9 years ago

@FilipB Thank you for your valuable feedback!

vnugent commented 9 years ago

Can you add the failing tests to the known-failure group, eg @Test(groups={"known-failure"})?

jkandasa commented 9 years ago

@vnugent marked alerts failure test cases with @Test(groups={"known-failure"})

vnugent commented 9 years ago

@jkandasa can you pull and rebase new changes I added to master? test in travis should pass with the new known-failure exclusion