Updating specs to pass on latest hawkular-services with hawkular java… - Githubissues

hawkular / hawkular-client-ruby

Ruby client for Hawkular

http://hawkular.org/

Apache License 2.0

8 stars 28 forks source link

Updating specs to pass on latest hawkular-services with hawkular java… #218

Closed josejulio closed 7 years ago

josejulio commented 7 years ago

…agent

The scope of this PR is to make the tests compatible when running on against a hawkular-services with javaagent 0.37.0.Final.

The agent is on a different path. The API to fetch the resources types is now used to successfully select any of the two agent types. Some other tests required small changes.

// cc @pilhuhn

coveralls commented 7 years ago

Coverage decreased (-1.2%) to 94.704% when pulling c8d182ff6a31f6cb494804055cb1e61238c272bf on josejulio:fetch_agent into 50ec0f60ba765b6a5d053430958b490ccfb0bd10 on hawkular:master.

coveralls commented 7 years ago

Coverage increased (+0.03%) to 95.971% when pulling 0df7a230e8232de160dd0a1fc71af59ca91fb800 on josejulio:fetch_agent into 50ec0f60ba765b6a5d053430958b490ccfb0bd10 on hawkular:master.

coveralls commented 7 years ago

Coverage increased (+0.03%) to 95.971% when pulling ac026c574990c0f3e23739b23ab1186eb6769099 on josejulio:fetch_agent into 50ec0f60ba765b6a5d053430958b490ccfb0bd10 on hawkular:master.

coveralls commented 7 years ago

Coverage decreased (-0.007%) to 95.935% when pulling dd47f8a6e939825781fde5594104d0c0e5e73e98 on josejulio:fetch_agent into 50ec0f60ba765b6a5d053430958b490ccfb0bd10 on hawkular:master.

coveralls commented 7 years ago

Coverage decreased (-0.4%) to 95.535% when pulling 5b9239d7cb0c01b4801eb29c20d38253af053009 on josejulio:fetch_agent into 50ec0f60ba765b6a5d053430958b490ccfb0bd10 on hawkular:master.

coveralls commented 7 years ago

Coverage decreased (-0.007%) to 95.935% when pulling b4d5450fedd13ea055bc2a5f00ab752bed5d57ff on josejulio:fetch_agent into 50ec0f60ba765b6a5d053430958b490ccfb0bd10 on hawkular:master.

josejulio commented 7 years ago

Finally green...

Had to modify the hawkular-javaagent-config.yaml from the hawkular-services image a bit to scan more frequently.

josejulio commented 7 years ago

Also, this should make hawkular-bot happy.

josejulio commented 7 years ago

@israel-hdez could you take a look please?

israel-hdez commented 7 years ago

I'm merging if nothing else is needed.