Update VCR cassettes to work correctly with VCR3+

hawkular / hawkular-client-ruby

Ruby client for Hawkular

http://hawkular.org/

Apache License 2.0

8 stars 28 forks source link

Update VCR cassettes to work correctly with VCR3+ #221

Closed cfcosta closed 7 years ago

cfcosta commented 7 years ago

The cassette's format was changed, with the removal of basic auth from the URL, being moved to its own Authorization header field.

This is part of the effort to make the gem support Ruby 2.4.

References: https://github.com/ManageIQ/manageiq-providers-hawkular/pull/17 https://github.com/ManageIQ/manageiq/pull/14270

cfcosta commented 7 years ago

@Jiri-Kremser @cben @jrafanie can you take a look at this, please?

jrafanie commented 7 years ago

Nice @cfcosta, does this branch work for you with ruby 2.4? If so, we can then add it to the .travis.yml test matrix in a followup... or here.

Awesome ❤️

jrafanie commented 7 years ago

@cfcosta hmm, can you try with webmock ~> 2.3.1 to see if this passes on ruby 2.4? I wonder if we're hitting another upgrade issue when we go to webmock 3+.

josejulio commented 7 years ago

The current error could be a 'bug' from the websocket library (some tests fail from time to time) or some bug not related to this one (I have seen that fail on other PRs). It could be fixed by #205. For now, I've restarted the test to see if it passes.

coveralls commented 7 years ago

Coverage increased (+0.004%) to 95.976% when pulling a28c204826b94e601142645c5fb1043a238c8355 on cfcosta:update-vcr-cassettes into 7f7c771245de09ae8aa59dd43b6c59af071cf0ab on hawkular:master.

jkremser commented 7 years ago

If @josejulio confirms, it can be merged