hawkular / hawkular-client-ruby

Ruby client for Hawkular
http://hawkular.org/
Apache License 2.0
8 stars 28 forks source link

[hawkular-1259] Fixing all tests #242

Closed jotak closed 6 years ago

jotak commented 6 years ago
jotak commented 6 years ago

Note: this PR is based on #240 , which should be merged first, and then this one rebased Commits displayed here include commits of #240.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.3%) to 96.731% when pulling 5e13d1569f3518bd1553228221cec2f7ee43fe60 on jotak:fix-all-tests into 0b4a39e52a12269d0bbae1d24f59a308a0b35d8e on hawkular:hawkular-1259.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.04%) to 96.955% when pulling 5e13d1569f3518bd1553228221cec2f7ee43fe60 on jotak:fix-all-tests into 0b4a39e52a12269d0bbae1d24f59a308a0b35d8e on hawkular:hawkular-1259.

jotak commented 6 years ago

PS: travis is lying. It works :)

josejulio commented 6 years ago

PS: travis is lying. It works :)

A good kick made it reconsider.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.09%) to 97.012% when pulling e0c55ec6b1f6e3e6628b8144dd9476e612267e62 on jotak:fix-all-tests into a5f4ec1230b2dea9a9c372dc76c040b11f54372c on hawkular:hawkular-1259.

jshaughn commented 6 years ago

This looks good to me. Not sure why it is not yet merged as we need to get the 1259 work completed. I'll merge now, follow-on work can be done in other PR's.