hawkular / hawkular-client-ruby

Ruby client for Hawkular
http://hawkular.org/
Apache License 2.0
8 stars 28 forks source link

HAWKULAR-1324 inventory model designed for prometheus #246

Closed jotak closed 6 years ago

jotak commented 6 years ago
jotak commented 6 years ago

Note: the FIXMEs in code should be fixed via another PR (with JIRA https://issues.jboss.org/browse/HAWKULAR-1293 )

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-24.6%) to 72.354% when pulling 82cbffec0b4b5951aa80c040f884819739f3a3c2 on jotak:inventory-prometheus into a4f5c64242b7f226dba20d25e8d938a49ccc5691 on hawkular:hawkular-1275.

jotak commented 6 years ago

@josejulio , @rubenvp8510 : I've reset this PR to take back Cassandra & Hawkular Metrics, but the big difference is that now it's a separate thing from the "hawkular client", since they don't share connection settings. In other words, the metrics client needs to be created directly and not through hawkular client.

Another consequence is that some integration tests, that were testings metrics provided by agent/hServices, are not valid anymore so I removed them.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.08%) to 96.917% when pulling 4c9c4011b72743b67f23b152d41dea0012671c19 on jotak:inventory-prometheus into a4f5c64242b7f226dba20d25e8d938a49ccc5691 on hawkular:hawkular-1275.