search

hawkular / hawkular-client-ruby

Ruby client for Hawkular
http://hawkular.org/
Apache License 2.0
8 stars 28 forks source link

[WIP][HAWKULAR-1293] Add a Prometheus client #249

Closed lucasponce closed 6 years ago

lucasponce commented 6 years ago

Please don't merge yet. This is a WIP and it would need a counterpart in MiQ repos. I will add additional api methods as long as we need it.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.06%) to 96.899% when pulling 55ed46f787b87659b9844c2e7045ce13e1cf1739 on lucasponce:p8s_api into 73a9699625ace04f065d18df5b6e71696bf7c1d7 on hawkular:hawkular-1275.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.2%) to 96.773% when pulling c832eaeabef238fddf6f784dc40917af1b0e0c17 on lucasponce:p8s_api into 73a9699625ace04f065d18df5b6e71696bf7c1d7 on hawkular:hawkular-1275.

lucasponce commented 6 years ago

@cfcosta thx for your comments. Two things, this is a WIP, and it is not yet ready for review. I will try to add your comments, but I would not include refactoring of style for consistency with other files in the client. Those refactors are good but I think they should go in a separate PR to not mix with this logic.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.3%) to 96.7% when pulling f83bb6b3a4773ddfa9305994e6241ea42a782948 on lucasponce:p8s_api into 73a9699625ace04f065d18df5b6e71696bf7c1d7 on hawkular:hawkular-1275.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.3%) to 96.656% when pulling 5e3d2db37575a0bfa0931c5db4051b6476f0bd67 on lucasponce:p8s_api into 73a9699625ace04f065d18df5b6e71696bf7c1d7 on hawkular:hawkular-1275.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.3%) to 96.656% when pulling 5e3d2db37575a0bfa0931c5db4051b6476f0bd67 on lucasponce:p8s_api into 73a9699625ace04f065d18df5b6e71696bf7c1d7 on hawkular:hawkular-1275.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.3%) to 96.656% when pulling d07378a9c7e174a4c3d22a47c2408c497233a730 on lucasponce:p8s_api into 73a9699625ace04f065d18df5b6e71696bf7c1d7 on hawkular:hawkular-1275.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.03%) to 96.935% when pulling a37c047d4a7e2c591e56ce57e0f2d92ab4f6cd39 on lucasponce:p8s_api into 73a9699625ace04f065d18df5b6e71696bf7c1d7 on hawkular:hawkular-1275.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.02%) to 96.943% when pulling 7d27513ecd1907357187dc227e64a35fba10c8fc on lucasponce:p8s_api into 73a9699625ace04f065d18df5b6e71696bf7c1d7 on hawkular:hawkular-1275.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.08%) to 96.879% when pulling 263b8796a86bb93c0ce367f84f11c98c70e4d685 on lucasponce:p8s_api into 73a9699625ace04f065d18df5b6e71696bf7c1d7 on hawkular:hawkular-1275.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.06%) to 96.902% when pulling 4c9a055e7b7b20eeaef1182d678528f1d6d4b3a8 on lucasponce:p8s_api into 73a9699625ace04f065d18df5b6e71696bf7c1d7 on hawkular:hawkular-1275.

lucasponce commented 6 years ago

I'm going to close this PR, as I am going to consolidate changes from a different branch.