search

hawkular / hawkular-client-ruby

Ruby client for Hawkular
http://hawkular.org/
Apache License 2.0
8 stars 28 forks source link

Hawkular 1328 #252

Closed jshaughn closed 6 years ago

jshaughn commented 6 years ago

These changes support both live-metrics and live-alerting in the hawkular-1328 branches.

@israel-hdez , @josejulio There are a lot of changed files here but many of them are vcr cassettes. Please review. We need this merged to support the 1328 branches.

@lucasponce this supersedes https://github.com/hawkular/hawkular-client-ruby/pull/250, so I will close it.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.1%) to 96.909% when pulling 86646172e6b84e48bcb29f46d437401204c47929 on jshaughn:hawkular-1328 into f0e020fd54d3a75f943eaf4e6af238dfedc53d92 on hawkular:master.

jshaughn commented 6 years ago

@israel-hdez Replied to comments and made some updates...

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.1%) to 96.906% when pulling 71d4d8d2e4be19b9b7c45f583e3f7d0986fb5f4c on jshaughn:hawkular-1328 into f0e020fd54d3a75f943eaf4e6af238dfedc53d92 on hawkular:master.

israel-hdez commented 6 years ago

Strangely, the tests are ok with the cassettes, but failing with the live servers. I'll merge... I hope we can fix live test in another PR.