search

hawkular / hawkular-datamining

Real-time time series prediction library with standalone server
36 stars 22 forks source link

use metrics as CDI bean #73

Closed pavolloffay closed 8 years ago

pavolloffay commented 8 years ago

Access metrics storage through CDI bean.

It is related to https://github.com/hawkular/hawkular-metrics/pull/502 so it should be merged after it.

pavolloffay commented 8 years ago

@Jiri-Kremser could you please review?

jkremser commented 8 years ago

Good job, just a question. Now, that it looks like the accounts will not be used anymore, is this actually still needed?

pavolloffay commented 8 years ago

Good point, this might be faster than accessing Metrics via REST API. But it also comples these together (which I don't like). On the other hand Datamining injects Inventory too and dist artifact is designed to be deployed inside Hawkular with other components.

Summary how I see it: -- tightly coupled together ++ faster than REST calls

@Jiri-Kremser and @pilhuhn what do you think? Should be this merged or wait until accounts are removed and use its REST API and assume that accounts will be "never used".

pavolloffay commented 8 years ago

https://github.com/hawkular/hawkular-metrics/pull/502 got merged. I would like to merge this too if nobody is against.