Improve querying with tags suggestion

jotak commented 7 years ago

Thanks to an enhancement on a the server side (https://issues.jboss.org/browse/HWKMETRICS-532), we can improve querying for metrics. I suggest:

Removing the "query by id" vs "query by tags" selector and replace it with an unified querying panel
This unified panel allows to provide both tags and metric name at the same time.
Tags are now suggested thanks to HWKMETRICS-532
Providing tags allows to refine metrics suggestion. Ie. if you have tons of metrics and it's difficult to scroll across all of them in suggestions, you can provide some tags to filter them
You can provide tags only, omitting the metric name, in which case we would have the same behaviour as now with "query by tag".
When a metric name is provided, tags are not used for querying. They're only present for easier metric suggestion
In other words there's no change in the way metrics datapoints are fetched. Changes are only for metrics & tags suggestion in graph's editing panel.

jotak commented 7 years ago

This enhancement would be active for metrics >= 0.22.0. Current behaviour will still apply for earlier server versions.

tsegismont commented 7 years ago

Simplifying sounds good to me, but can you give an example of what a user would type to differentiate a metric name from a metric tag if there's a single text box?

2017-01-16 11:15 GMT+01:00 Joel Takvorian notifications@github.com:

This enhancement would be active for metrics >= 0.22.0. Current behaviour will still apply for earlier server versions.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hawkular/hawkular-grafana-datasource/issues/49#issuecomment-272822181, or mute the thread https://github.com/notifications/unsubscribe-auth/ABbltid4vs2Oy_h1S1gv8SFSunv_r2xLks5rS0NRgaJpZM4LkYdQ .

jotak commented 7 years ago

My idea would be not to have a single text field, but maybe 2, on two lines: one for query, one for tag. I'm not totally decided yet on what to suggest... I'll post an example screenshot to illustrate.

jotak commented 7 years ago

(and of course it's open for discussion. I'll open a thread on the ml)

jotak commented 7 years ago

There's a new upcoming feature in Hawkular, a "tags query language" ( https://issues.jboss.org/browse/HWKMETRICS-523 ). I'll know more about it this afternoon, it may worth to integrate it somehow in Grafana.

jotak commented 7 years ago

replaced with #52

hawkular / hawkular-grafana-datasource

Improve querying with tags suggestion #49