search

hawkular / hawkular-openshift-agent

A Hawkular feed that collects metrics from Prometheus and/or Jolokia endpoints deployed in one or more pods within an OpenShift node.
16 stars 21 forks source link

tag metric definitions with Prometheus labels #128

Closed jmazzitelli closed 7 years ago

jmazzitelli commented 7 years ago

Today, Prometheus labels are added to our H-Metrics DATA POINTS. They are not added to metric definitions.

We should add Prometheus labels to H-Metric metric definitions if we can. Preferrably automatically without having the user configuration anything. But if we can't, maybe support the token ${METRIC:tag[the-prometheus-tag]} in the endpoint "tags:" section.

jmazzitelli commented 7 years ago

This is what I'm going to do (and I almost have working now):

The Prometheus labels can be used for other tags via ${METRIC:tag[prometheus-label]} - so you can use that in the tags section in endpoint: or metrics: sections.

H-Metrics metric definition will have all Prometheus labels added as individual tags.

Also: default description will append {label=value,...} at the end of the Prometheus description - this is issue #131