search

hawkular / hawkular.github.io

Web presence of Hawkular
Apache License 2.0
9 stars 29 forks source link

Blog post - OpenTracing EJB framework integration #332

Closed jpkrohling closed 7 years ago

jpkrohling commented 7 years ago

@kevinearls , would you please test this? @objectiser , @jstickler , once Kevin tests this, would you please proofread and review?

jpkrohling commented 7 years ago

OpenTracing EJB integration

jpkrohling commented 7 years ago

Just wondering about the amount of code - is it better to have a repo with "here is one I made earlier" - and just show some code snippets in the blog?

I would love to get the feedback from others as well. Personally, I prefer to see the full code, as I can check where the classes being used are coming from (package names) and I know exactly what's needed to get that code running.

In any case, apart from the pom.xml, the code is a copy of the existing OT EJB Example linked in the first paragraphs (... Our demo project is heavily based on the ...). I could also provide a ZIP file with the final outcome. Would that be useful?

objectiser commented 7 years ago

Agree wait for others to also comment - but it is generally useful to provide a complete version of the source for those who just want to try it out quickly.

jpkrohling commented 7 years ago

Most of the items were fixed, except the one about @Inject and the purpose of the AccountService.

jpkrohling commented 7 years ago

Package names changed, and removed the Application, as Swarm provides that already.

jpkrohling commented 7 years ago

This has been tested and reviewed by @JStickler and @objectiser . Will merge on Friday, unless anybody else has any objections.