@hawkw I dunno if this was intentional for some other reason, but it seems like the "init tracing" helper returned a guard that the caller is supposed to hold, but none (or not all?) of the tests that called it actually held it.
This makes a single return type (because rustc was Big Mad when I used Box<dyn Drop>) based on the features, and marks it as must use.
If you want me to rebase this on main instead of your test branch, lemme know.
jamesmunns
commented
1 year ago
@hawkw I dunno if this was intentional for some other reason, but it seems like the "init tracing" helper returned a guard that the caller is supposed to hold, but none (or not all?) of the tests that called it actually held it.
This makes a single return type (because rustc was Big Mad when I used
Box<dyn Drop>) based on the features, and marks it as must use.If you want me to rebase this on
maininstead of your test branch, lemme know.