search

hawkw / thingbuf

in-place allocation-reusing queues for Rust
MIT License
287 stars 24 forks source link

fix: try_recv_ref should return RecvRef #61

Closed name1e5s closed 2 years ago

name1e5s commented 2 years ago

try_recv_ref should return a RecvRef to notify the sender threads to wake up.

@hawkw r?

name1e5s commented 2 years ago

thanks, this looks good to me.

we probably should have written some tests exercising try_recv_ref so we would have caught this sooner...are you interested in adding some now? this would be fine to do in a separate PR...

Hmm, I'll write some tests and submit a new PR this Friday.

hawkw commented 2 years ago

@name1e5s sounds good --- I went ahead and merged the bugfix. Thank you!