hawtio / hawtio-core-navigation

The main navigation component for hawtio
Apache License 2.0
1 stars 7 forks source link

dependency on lodash in bower.json is too specific #12

Closed benjaminapetersen closed 8 years ago

benjaminapetersen commented 8 years ago

This may apply to other dependencies as well, but having the lodash version set so specifically to "lodash": "~3.2.0", is very restrictive. Lodash is upto 3.10.1 on 3.x & is backwards compatible. I'd like to pick up a newer version in the OpenShift web console, but this dependency set in hawtio-core-navigation" causes bower to fail install with ECONFLICT Unable to find suitable version for lodash.

benjaminapetersen commented 8 years ago

I'd take a stab at suggesting "lodash": ">=3.2.0 <4.0.0", would be reasonable, the lodash changelog looks like pretty strict semver & this range would ease version lock.

liggitt commented 8 years ago

No, we need an exact version to lock the built bindata.go. We can experiment with an exact version that would fit our needs though

gashcrumb commented 8 years ago

I'd be happy to bump this version up for sure

liggitt commented 8 years ago

Nm, didn't notice which repo this was against. Sure, a version range here could make sense

gashcrumb commented 8 years ago

Should mention you should be able to use an override in bower to sort this out as well. But we should bump it up anyways

benjaminapetersen commented 8 years ago

Using a resolutions block in OpenShift's bower does seem to work to force an override:

"resolutions": {
    "lodash": "3.10.0"
},

But I prob would still prefer more flexibility in dependency definition.

gashcrumb commented 8 years ago

Awesome, feel free to send along a PR and I can release a new version easily enough, thanks!

benjaminapetersen commented 8 years ago

ok will try to hit that today!

abkieling commented 8 years ago

@gashcrumb I believe this issue can be closed. The change to "lodash": ">=3.2.0 <4.0.0" has already been made.

gashcrumb commented 8 years ago

Yup, agreed!