search

hawtio / hawtio-kubernetes

hawtio plugin for working with kubernetes
Apache License 2.0
24 stars 14 forks source link

the overview page should link to the Deployment / DeploymentConfig ideally rather than RC/RS #132

Closed jstrachan closed 7 years ago

jstrachan commented 7 years ago

also would be nice to have a Configure button like the Deployment page maybe?

gashcrumb commented 7 years ago

Agreed! I can take a look at this if you're not already on it...

jstrachan commented 7 years ago

@gashcrumb go for it! :)

gashcrumb commented 7 years ago

Wonder, should I assume the Deployment/Deployment config name is going to be the same as the app name? Thinking I might try and get these associated with the app structure that we put together in KubernetesModel.

jstrachan commented 7 years ago

@gashcrumb yeah that sounds like a good default. as in if the names match, lets try associate them in the UI pages

jstrachan commented 7 years ago

I guess a Deployment / RC could refer to N different config maps in the env.valueFrom or volume metadata too really ;) - but assuming the names match sounds a nice simple default really - as a Deployment can use 0..N ConfigMaps really

gashcrumb commented 7 years ago

So what I was kinda thinking was to rework the current logic that creates the 'app' objects to just associated all the related objects via the Deployment/DeploymentConfig's selectors, would still though have to fall back onto using an RC's selector as well as for example fabric8-console doesn't use a Deployment looks like. But then the 'app' object will have all the associated things uh... associated :-)

Like this: capture

jstrachan commented 7 years ago

sounds good! For added complication the ConfigMaps are not associated using the selectors; they are in the spec.container.env.valueFrom object (for mapping configmap entries to env vars) or spec.volume for configmap volumes - so if you wanted to be totally accurate then we should use that metadata to do the association.

gashcrumb commented 7 years ago

Ah, I see, tricky! I'll try and get that association made too, might as well make it accurate.

jstrachan commented 7 years ago

I guess lots of our apps have the same-name association (e.g. gogs, jenkins, nexus etc). For Volume association you could use this quickstart: https://github.com/fabric8-quickstarts/spring-boot-webmvc/blob/master/src/main/fabric8/deployment.yml#L7

i.e. a volume of kind configMap then the name is inside that object. Don't have an env.valueFrom example to hand right now...

gashcrumb commented 7 years ago

Have the env.valueFrom part sorted, just have to handle volumes...

On Sep 19, 2016 4:46 PM, "James Strachan" notifications@github.com wrote:

I guess lots of our apps have the same-name association (e.g. gogs, jenkins, nexus etc). For Volume association you could use this quickstart: https://github.com/fabric8-quickstarts/spring-boot- webmvc/blob/master/src/main/fabric8/deployment.yml#L7

i.e. a volume of kind configMap then the name is inside that object. Don't have an env.valueFrom example to hand right now...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hawtio/hawtio-kubernetes/issues/132#issuecomment-248121021, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVdrFDWGBsOsRCsk1Q-f7TlmeM6nOKWks5qrvSggaJpZM4KApz5 .

jstrachan commented 7 years ago

I guess if a D/Dc/app has > 1 config the config icon could generate a drop down to list them all by name?

gashcrumb commented 7 years ago

oh yeah, definitely that'd be ideal...