search

hawtio / hawtio-kubernetes

hawtio plugin for working with kubernetes
Apache License 2.0
24 stars 14 forks source link

Logs and Chat button - Please open in new tab #64

Open davsclaus opened 9 years ago

davsclaus commented 9 years ago

Similar to #57

But these open in new tab. Wonder if projects should open in new tab too? I would think so.

screen shot 2015-07-14 at 11 27 58 am

@gashcrumb a few more still

davsclaus commented 9 years ago

Projects is okay as is, as the Kubernetes button is still shown so you can go back easily.

davsclaus commented 9 years ago

I guess @gashcrumb this is a bit harder? As those top nav button is from each plugin. Wonder if we could add some option/metadata to each plugin that tells whether clicking that button should be in current window or new tab?

Then we can configure Logs / Chat / Metrics to open in new tab.

gashcrumb commented 9 years ago

I wonder though, with the launcher now, do we really need these top-level links? It seems odd in general to have a link in the main nav bar that opens a new tab amidst other links that don't...

jstrachan commented 9 years ago

ah good point!

davsclaus commented 9 years ago

And by the launcher do you refer to 'open' menu or what do you mean?

gashcrumb commented 9 years ago

Yeah, the open menu, couldn't remember what we called it :-)

davsclaus commented 9 years ago

I like the top bar buttons - the open menu may easily get cluttered, our devops install got like 20 or so.

Also for chat in the open menu you would need to know its letschat (okay it has chat in name) but then for logs, you will be lost not knowing its kibana etc.