search

hawtio / hawtio-kubernetes

hawtio plugin for working with kubernetes
Apache License 2.0
24 stars 14 forks source link

the Open > link on the console uses the Route host name and the service port. We should not use the service port for route URLs #65

Closed jstrachan closed 9 years ago

jstrachan commented 9 years ago

e.g. this link:

http://quickstart-camelservlet.vagrant.f8:9101/

should not include the service port 9101

davsclaus commented 9 years ago

Here is a screenshot with example

screen shot 2015-07-15 at 10 40 58 am

davsclaus commented 9 years ago

@gashcrumb you have any tips where this code is that shows this menu and populate it?

davsclaus commented 9 years ago

Ah found it here https://github.com/hawtio/hawtio-kubernetes/blob/master/plugins/kubernetes/ts/kubernetesPlugin.ts#L162-162

jstrachan commented 9 years ago

here's the rendering code https://github.com/hawtio/hawtio-kubernetes/blob/master/plugins/kubernetes/html/serviceApps.html#L8-8

the link is created here https://github.com/hawtio/hawtio-kubernetes/blob/master/plugins/kubernetes/ts/kubernetesModel.ts#L271-271

looks like its a bug in this function https://github.com/hawtio/hawtio-kubernetes/blob/master/plugins/kubernetes/ts/kubernetesHelpers.ts#L413-413

which should ignore the port if its a route host (rather than a portal IP)

davsclaus commented 9 years ago

Yeah I am using the same link as on the services page

jstrachan commented 9 years ago

yay!