Where is hawtio-json-schema-generator maven plugin now located?

[phantomjinx]

This maven plugin is used to generate the required version of the camel model json. It is published to maven central but the source is only available from the hawtio/hawtio 1.x branch. It was then removed(?). Where is it now located if at all and if it was never moved elsewhere, should it be??

• [x] Issue #1 - Tidy up Tasks
• [x] Issue #2 - Migrate project to hawtio organisation

[tadayosi]

Right, we still uses 1.x version from the old branch because it just works fine. We can restore it to the latest 3.x branch if needed. Or you can use it as-is for the time being.

[phantomjinx]

Right, we still uses 1.x version from the old branch because it just works fine. We can restore it to the latest 3.x branch if needed. Or you can use it as-is for the time being.

Might be good to publish it to its own repository. I'll maybe have a look at that next week.

[tadayosi]

Yes, splitting it into another repo under hawtio org is another option. I'm not sure if we can reuse the same settings and credentials to publish a Maven plugin to Maven Central, but please go ahead with the option.

[phantomjinx]

@tadayosi

Have migrated and updated the generator to https://github.com/phantomjinx/hawtio-camel-catalog-schema-generator. Can you review and provide any comments, please?

Changes

• Ported the original 1.4.x;
• Updated dependencies to latest versions;
• Split the generator from the mojo to allow for unit testing;
• Removed old 'test' and created a new junit 5 test to test the generator (rather than the mojo - since testing with maven's test-harness is fraught with difficulties that saps away time);
• Added components to model schema;
• Added github actions for building and testing;

[tadayosi]

@phantomjinx Thanks, that's great! I think it's almost ok, but there are a few minor comments.

Implementation

• I see the impl still partly depends on a legacy part of Hawtio. I think the only needed dependency is io.hawt.jsonschema.SchemaLookup. Then, we can also copy it to the project and remove the dependency.

  2.0-M3
• Maybe we can stop using commons-lang, as the only usage seems to be Validate.notNull() and you can use Objects.requireNonNull() instead.

Styling and structure

• Let's use spaces for indentation (I see some files use tabs)
• Unless we plan to host more than one maven plugin, I don't think we need to have a nested Maven project structure. We could simply flatten it and move hawtio-camel-catalog-schema-generator-plugin top level.
• Once we transter it to hawtio org, we can rename it to hawtio/camel-catalog-schema-generator-plugin

That said, overall it looks great already and we can start improving it from here. Why don't we transfer the project to hawtio org?

I think the remaining thing to do is:

• Copy release profile and script from the main Hawtio project so that it can be published to Maven Central Repo. https://github.com/hawtio/hawtio/blob/main/pom.xml#L258-L327 https://github.com/hawtio/hawtio/blob/main/bin/release (I'm not sure if we can use the same credentials for publishing the maven plugin as well, or we should file another JIRA ticket to OSSRH for this project again: https://central.sonatype.org/publish/publish-guide/)

[tadayosi]

One more question.

Added components to model schema;

What does it mean from the Hawtio.next point of view? Do we need to change the Camel plugin to utilise the new info from the model?

UPDATE: Ah, ok. It's needed for https://github.com/hawtio/hawtio-next/issues/21#issuecomment-1485544118.

[phantomjinx]

What does it mean from the Hawtio.next point of view? Do we need to change the Camel plugin to utilise the new info from the model?

The camel-model package will end up with a new camelModel.ts once the co-ordinates in its pom will be updated. However, even before its published, I can update the camelModel.ts manually with a locally generated version.

[phantomjinx]

0.0.1 published in mvnrepository