hawtio / hawtio-next

Next generation Hawtio UI console
https://hawt.io
Apache License 2.0
7 stars 22 forks source link

refactor(charts): Refactor Chart page #846

Closed mmelko closed 6 months ago

mmelko commented 6 months ago

fix: #437 fix: #489 fix: #624 In addition I added a possibility to show only charts for attributes with values actually changing in time. I also added dynamic min value for y axis to actually show some scale. Charts should be responsive now. Improved loading performance

Screenshot 2024-03-28 at 22 11 59

branch: mmuzikar:mmuzikar-ci-test-branch

github-actions[bot] commented 6 months ago

Test Results

  8 files  ±0    8 suites  ±0   43m 55s :stopwatch: + 5m 28s  60 tests ±0   56 :white_check_mark:  -  2   2 :zzz: ±0   2 :x: + 2  488 runs  ±0  444 :white_check_mark:  - 16  28 :zzz: ±0  16 :x: +16 

For more details on these failures, see this check.

Results for commit f94d6fbc. ± Comparison against base commit f3539230.

:recycle: This comment has been updated with latest results.

tadayosi commented 6 months ago

In addition I added a possibility to show only charts for attributes with values actually changing in time.

image

Now you are using a checkbox but it looks a bit primitive. You can instead use a switch: https://v4-archive.patternfly.org/v4/components/switch

mmelko commented 6 months ago

In addition I added a possibility to show only charts for attributes with values actually changing in time.

image

Now you are using a checkbox but it looks a bit primitive. You can instead use a switch: https://v4-archive.patternfly.org/v4/components/switch

great suggestion! thanks

hawtio-ci[bot] commented 6 months ago

Test results

Run attempt: 1418 Detailed summary NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
results-quarkus-node(18)-java(17)-firefox 61 56 3 2 0 326.294
results-quarkus-node(18)-java(21)-firefox 61 56 3 2 0 323.285
results-quarkus-node(20)-java(17)-firefox 61 56 3 2 0 339.94
results-quarkus-node(20)-java(21)-firefox 61 56 3 2 0 329.748
results-springboot-node(18)-java(17)-firefox 61 55 4 2 0 333.729
results-springboot-node(18)-java(21)-firefox 61 55 4 2 0 333.213
results-springboot-node(20)-java(17)-firefox 61 55 4 2 0 322.917
results-springboot-node(20)-java(21)-firefox 61 55 4 2 0 326.405
mmelko commented 6 months ago

@tadayosi I forgot to remove WIP yesterday. Can you check ? Performance is now better, although still not ideal due to processing batch of requests.

tadayosi commented 6 months ago

The failing tests should be only related to Charts.