hawtio / hawtio-next

Next generation Hawtio UI console
https://hawt.io
Apache License 2.0
7 stars 22 forks source link

Migrate Contexts,Exchanges,Attributes to TableComposable #869

Closed mmelko closed 5 months ago

mmelko commented 5 months ago

I migrated tables to use TableComposable instead of old PF4 table. Also fixed #845 by refactoring selected const to use list of strings instead Context objects. close #180

github-actions[bot] commented 5 months ago

Test Results

  8 files  ±0    8 suites  ±0   47m 0s :stopwatch: +15s  60 tests ±0   58 :white_check_mark: ±0   2 :zzz: ±0  0 :x: ±0  488 runs  ±0  460 :white_check_mark: ±0  28 :zzz: ±0  0 :x: ±0 

Results for commit 9134609b. ± Comparison against base commit cecba475.

:recycle: This comment has been updated with latest results.

hawtio-ci[bot] commented 5 months ago

Test results

Run attempt: 1460 Detailed summary NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
results-quarkus-node(18)-java(17)-firefox 61 58 3 0 0 358
results-quarkus-node(18)-java(21)-firefox 61 58 3 0 0 347.759
results-quarkus-node(20)-java(17)-firefox 61 58 3 0 0 349.102
results-quarkus-node(20)-java(21)-firefox 61 58 3 0 0 346.293
results-springboot-node(18)-java(17)-firefox 61 57 4 0 0 348.161
results-springboot-node(18)-java(21)-firefox 61 57 4 0 0 348.582
results-springboot-node(20)-java(17)-firefox 61 57 4 0 0 359.488
results-springboot-node(20)-java(21)-firefox 61 57 4 0 0 363.306
mmelko commented 5 months ago

@tadayosi I don't think that was a problem actually. Contexts component is fairly simple. My impression was that problem was that for selectedState was used actually array of the ContextState objects. I assume it could be a problem of references in the array. Refactoring the selected state to actually to the array of the strings did the trick