hawtio / hawtio-next

Next generation Hawtio UI console
https://hawt.io
Apache License 2.0
7 stars 22 forks source link

WIP: refactor(CamelContent): Refactor to use tabs instead of Navigation and React routes #882

Closed mmelko closed 5 months ago

mmelko commented 5 months ago

branch: jsolovjo:e2e-tests-fix-ux-changes-pr-882

I used Tabs elements instead of the Tertiary navigation which is deprecated in the patternfly 5. Tabs are rendering only on click and are demounted from the DOM so the behaviour is the same except we don't have the items in the path as we had before. But for the camel it didn't work anyway.

Using tabs instead of the navigation makes styles bit more tight:

Screenshot 2024-04-17 at 21 45 00 Screenshot 2024-04-17 at 21 45 10

I have to sort out some issues, but the question is if we want to go this route.

github-actions[bot] commented 5 months ago

Test Results

  8 files  ±0    8 suites  ±0   50m 27s :stopwatch: +3s  66 tests ±0   64 :white_check_mark: +2   2 :zzz: ±0  0 :x:  - 2  536 runs  ±0  508 :white_check_mark: +2  28 :zzz: ±0  0 :x:  - 2 

Results for commit 3ea9106e. ± Comparison against base commit 314b9c88.

:recycle: This comment has been updated with latest results.

hawtio-ci[bot] commented 5 months ago

Test results

Run attempt: 1506 Detailed summary NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
results-quarkus-node(18)-java(17)-firefox 67 64 3 0 0 374.764
results-quarkus-node(18)-java(21)-firefox 67 64 3 0 0 375.259
results-quarkus-node(20)-java(17)-firefox 67 64 3 0 0 378.873
results-quarkus-node(20)-java(21)-firefox 67 64 3 0 0 383.561
results-springboot-node(18)-java(17)-firefox 67 63 4 0 0 374.593
results-springboot-node(18)-java(21)-firefox 67 63 4 0 0 382.349
results-springboot-node(20)-java(17)-firefox 67 63 4 0 0 381.811
results-springboot-node(20)-java(21)-firefox 67 63 4 0 0 375.913
mmelko commented 5 months ago

Closing for now,. I will do the style changes in the different PR without migration to tabs component.