hawtio / hawtio-next

Next generation Hawtio UI console
https://hawt.io
Apache License 2.0
7 stars 22 forks source link

fix(connect): HAWNG-487 apply authentication throttling to connect login #894

Closed tadayosi closed 5 months ago

tadayosi commented 5 months ago

https://issues.redhat.com/browse/HAWNG-487

tadayosi commented 5 months ago

@kariuwu @grgrzybek Can you please review this?

hawtio-ci[bot] commented 5 months ago

Test results

Run attempt: 1532 Detailed summary NAME TESTS PASSED βœ… SKIPPED πŸ’€ FAILED ❌ ERRORS 🚫 TIME πŸ•–
results-quarkus-node(18)-java(17)-firefox 67 64 3 0 0 377.527
results-quarkus-node(18)-java(21)-firefox 67 64 3 0 0 373.859
results-quarkus-node(20)-java(17)-firefox 67 64 3 0 0 373.743
results-quarkus-node(20)-java(21)-firefox 67 64 3 0 0 371.238
results-springboot-node(18)-java(17)-firefox 67 63 4 0 0 375.999
results-springboot-node(18)-java(21)-firefox 67 63 4 0 0 368.986
results-springboot-node(20)-java(17)-firefox 67 63 4 0 0 374.079
results-springboot-node(20)-java(21)-firefox 67 63 4 0 0 379.359
grgrzybek commented 5 months ago

Looks good - there are no changes required at hawtio/hawtio side, right?

github-actions[bot] commented 5 months ago

Test Results

  8 files  Β±0    8 suites  Β±0   49m 54s :stopwatch: +3s  66 tests Β±0   64 :white_check_mark: Β±0   2 :zzz: Β±0  0 :x: Β±0  536 runsβ€Š Β±0  508 :white_check_mark: Β±0  28 :zzz: Β±0  0 :x: Β±0 

Results for commit 57a035db. ± Comparison against base commit 131a2c83.

tadayosi commented 5 months ago

@grgrzybek Thanks.

Looks good - there are no changes required at hawtio/hawtio side, right?

No, no changes required. It's based on the existing capability in hawtio/hawtio.

However, just FYI, if we would look into HAWNG-487 more seriously, ideally there can be a few more enhancements from hawtio/hawtio and jolokia sides, including:

Anyway, we should work on them after product GA if we do.