Closed mmelko closed 1 month ago
8 files ±0 8 suites ±0 41m 55s :stopwatch: - 9m 25s 65 tests ±0 63 :white_check_mark: ±0 2 :zzz: ±0 0 :x: ±0 528 runs ±0 500 :white_check_mark: ±0 28 :zzz: ±0 0 :x: ±0
Results for commit fcfd77b0. ± Comparison against base commit 7e100a17.
:recycle: This comment has been updated with latest results.
Thanks @tadayosi for careful review - I admit, I simply assumed Matej did the best.
Run attempt: 1797 Detailed summary | NAME | TESTS | PASSED ✅ | SKIPPED 💤 | FAILED ❌ | ERRORS 🚫 | TIME 🕖 |
---|---|---|---|---|---|---|---|
results-quarkus-node(18)-java(17)-firefox | 66 | 63 | 3 | 0 | 0 | 319.333 | |
results-quarkus-node(18)-java(21)-firefox | 66 | 63 | 3 | 0 | 0 | 310.051 | |
results-quarkus-node(20)-java(17)-firefox | 66 | 63 | 3 | 0 | 0 | 311.642 | |
results-quarkus-node(20)-java(21)-firefox | 66 | 63 | 3 | 0 | 0 | 310.963 | |
results-springboot-node(18)-java(17)-firefox | 66 | 62 | 4 | 0 | 0 | 311.598 | |
results-springboot-node(18)-java(21)-firefox | 66 | 62 | 4 | 0 | 0 | 318.419 | |
results-springboot-node(20)-java(17)-firefox | 66 | 62 | 4 | 0 | 0 | 319.127 | |
results-springboot-node(20)-java(21)-firefox | 66 | 62 | 4 | 0 | 0 | 314.764 |
Thanks @tadayosi for careful review - I admit, I simply assumed Matej did the best.
Well I did:), or at least I tried diven that time and space ;)
finished review. at this point I'd like to request changes, as the way you changed around the curried callback functions is alarming and suspected that it breaks the code. please check them again.
Thanks for the review, as I mentioned you're right, I missed curried signatures of the functions. It also discovered other thing, and that is that are unit test suite could be better too.
I used
@patternfly/pf-codemods
to upgrade most of the things, then fixed errors and some warnings. And upgraded some tables. In the next iteration I will ged rid of the rest deprecated components, mainly Selects and Dropdowns. related to #477branch: jsolovjo:e2e-fix-patternfly5-tests