hawtio / hawtio-next

Next generation Hawtio UI console
https://hawt.io
Apache License 2.0
7 stars 20 forks source link

feat(shared,jmx): support serialising long to string in JSON response from Jolokia #970

Closed tadayosi closed 3 weeks ago

tadayosi commented 3 weeks ago

image

This fix limits the serializeLong=string option to JMX, because the change of the bahaviour might cause unexpected errors in other plugins. JMX is a generic MBeans manipulation plugin, so it should make sense to have such an option plugin-wide.

Each plugin should decide whether it's worth applying the option or not.

Fix #292

tadayosi commented 3 weeks ago

A bit more screenshots to demonstrate how it fixes the long values issue:

Without Serialize long to string (default)

image

With Serialize long to string

image

image

github-actions[bot] commented 3 weeks ago

Test Results

  8 files  ±0    8 suites  +1   36m 11s :stopwatch: - 2h 48m 33s  65 tests ±0   63 :white_check_mark: + 63   2 :zzz: + 2  0 :x:  -  65  463 runs  +1  439 :white_check_mark: +439  24 :zzz: +24  0 :x:  - 462 

Results for commit 817817f5. ± Comparison against base commit e7615685.

:recycle: This comment has been updated with latest results.

hawtio-ci[bot] commented 3 weeks ago

Test results

Run attempt: 1822 Detailed summary NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
results-quarkus-node(18)-java(17)-firefox 66 63 3 0 0 308.206
results-quarkus-node(18)-java(21)-firefox 66 63 3 0 0 308.332
results-quarkus-node(20)-java(17)-firefox 66 63 3 0 0 310.997
results-quarkus-node(20)-java(21)-firefox 66 63 3 0 0 309.128
results-springboot-node(18)-java(17)-firefox 66 62 4 0 0 308.222
results-springboot-node(18)-java(21)-firefox 66 62 4 0 0 307.478
results-springboot-node(20)-java(17)-firefox 1 1 0 0 0 7.095
results-springboot-node(20)-java(21)-firefox 66 62 4 0 0 311.558