search

hawtio / hawtio-next

Next generation Hawtio UI console
https://hawt.io
Apache License 2.0
7 stars 20 forks source link

fix: add missing aria-labels #982

Closed mmelko closed 3 weeks ago

mmelko commented 3 weeks ago

This PR adds missing aria-labels that caused warning in the console. Also remove defaultProps for the CamelIcon and replace it with JS defaults.

fix: #971

tadayosi commented 3 weeks ago

@mmelko Have you also tested that it fixes #971 at hawtio/hawtio? Like the console in a Quarkus or Spring Boot application.

github-actions[bot] commented 3 weeks ago

Test Results

  8 files  ±0    8 suites  ±0   36m 58s :stopwatch: +8s  66 tests ±0   64 :white_check_mark: ±0   2 :zzz: ±0  0 :x: ±0  470 runs  ±0  446 :white_check_mark: ±0  24 :zzz: ±0  0 :x: ±0 

Results for commit 5e407a14. ± Comparison against base commit a2722f48.

hawtio-ci[bot] commented 3 weeks ago

Test results

Run attempt: 1884 Detailed summary NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
results-quarkus-node(18)-java(17)-firefox 67 64 3 0 0 317.229
results-quarkus-node(18)-java(21)-firefox 67 64 3 0 0 315.061
results-quarkus-node(20)-java(17)-firefox 67 64 3 0 0 317.327
results-quarkus-node(20)-java(21)-firefox 67 64 3 0 0 316.653
results-springboot-node(18)-java(17)-firefox 67 63 4 0 0 313.404
results-springboot-node(18)-java(21)-firefox 67 63 4 0 0 317.401
results-springboot-node(20)-java(17)-firefox 67 63 4 0 0 314.679
results-springboot-node(20)-java(21)-firefox 1 1 0 0 0 7.152
mmelko commented 3 weeks ago

Yes, I double-checked that.