hawtio / hawtio-next

Next generation Hawtio UI console
https://hawt.io
Apache License 2.0
7 stars 20 forks source link

feat(camel-source): Make Source editor editable when it's enabled in the CamelContext #993

Closed mmelko closed 1 week ago

mmelko commented 1 week ago

When updating the routes is enabled then the editor in the Source tab under particular route becomes writable additional control/check is shown:

Screenshot 2024-06-24 at 15 54 45

When the code is changed:

Screenshot 2024-06-24 at 15 54 26

When it's saved the notification is fired and control button is changed back:

Screenshot 2024-06-24 at 15 54 33
github-actions[bot] commented 1 week ago

Test Results

  8 files  ± 0    8 suites  ±0   36m 48s :stopwatch: - 4m 44s  66 tests ± 0   64 :white_check_mark: ± 0   2 :zzz: ±0  0 :x: ±0  470 runs   - 66  446 :white_check_mark:  - 62  24 :zzz:  - 4  0 :x: ±0 

Results for commit ee99a71b. ± Comparison against base commit 10a0599f.

:recycle: This comment has been updated with latest results.

hawtio-ci[bot] commented 1 week ago

Test results

Run attempt: 1959 Detailed summary NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
results-quarkus-node(18)-java(17)-firefox 67 64 3 0 0 322.009
results-quarkus-node(18)-java(21)-firefox 67 64 3 0 0 308.276
results-quarkus-node(20)-java(17)-firefox 67 64 3 0 0 318.982
results-quarkus-node(20)-java(21)-firefox 67 64 3 0 0 317.41
results-springboot-node(18)-java(17)-firefox 67 63 4 0 0 311.89
results-springboot-node(18)-java(21)-firefox 67 63 4 0 0 313.074
results-springboot-node(20)-java(17)-firefox 1 1 0 0 0 6.976
results-springboot-node(20)-java(21)-firefox 67 63 4 0 0 309.43
tadayosi commented 1 week ago

@mmelko Which issue are you supposed to fix with this pull req? Please link it if there is.

mmelko commented 1 week ago

A few comments.

Also, have you checked that updating the route works when the context has multiple routes?

Well, the quickstart I tested has 2 routes. Also this operation is available not on context level but on route level.

As I mentioned, you won't be able to edit the source when you open it in the Routes view, you have to open source for specified route. Sorry I cut the screenshots too much so it's not obvious from there.