Discover should not be visible for the Integration console

hawtio / hawtio-online

Hawtio on Kubernetes/OpenShift

Apache License 2.0

23 stars 25 forks source link

Discover should not be visible for the Integration console #188

Open tadayosi opened 1 year ago

tadayosi commented 1 year ago

Discover should be provided only for the Online console, which is the entrance view for Hawtio Online. Once it's connected to a specific pod, Discover should be disabled.

phantomjinx commented 11 months ago

Disabling the Discover plugin will result in the dropdown being removed as well.

We currently do not have the API in hawtio/react to create a separate plugin that just provides the DropDown.

The Plugin API requires a title & component. Can set the component to () -> null but no workaround to title;
HawtioSidebar lists all plugins that implement the Plugin interface

Do we change the API at this stage?

tadayosi commented 11 months ago

@phantomjinx OK, I understand the issue now. So we need to extend the plugin API, but yeah let's do it after we release GA.

tadayosi commented 2 months ago

@phantomjinx According to @grgrzybek, hawtio/react v1.3.0 already includes a fix for hawtio/hawtio-next#704. You can apply the fix and try resolving the issue now.