hawtio / hawtio-online

Hawtio on Kubernetes/OpenShift
Apache License 2.0
23 stars 25 forks source link

Hawtio Online lists any pod having a port named jolokia, even if it's not serving jolokia resources #342

Closed mmuzikar closed 5 months ago

mmuzikar commented 6 months ago

I used quay.io/fuse_qe/http-https-echo image with the 8443 port named jolokia and hawtio-online makes requests to it, and even though it's not returning any jolokia responses it gets listed in the UI, but when you click on the connect button, it leads to a blank page.

tadayosi commented 6 months ago

@mmuzikar I think because that's the only (lightweight) way Hawtio Online can know whether a pod provides a Jolokia endpoint or not. I wonder why a pod names a port jolokia but without intention to provide a real Jolokia endpoint?

mmuzikar commented 6 months ago

It's definitely an edge case, I was thinking if it's possible to check the response if the response is jolokia based resource.

phantomjinx commented 5 months ago

I would say this has now been fixed.

Although the pod is listed since a port has been named jolokia it cannot be connected to since the probing of the port returns the error of unrecognized. This makes sense to me because:

Screenshot_20240322_132718