search

hawtio / hawtio-ui

Hawtio UI widgets for hawtio 2.x see http://ui.hawt.io/
Apache License 2.0
7 stars 6 forks source link

log an error when there isn't a primary key #20

Closed abkieling closed 8 years ago

abkieling commented 8 years ago

I've changed 'defaultPrimaryKeyFn' to throw an Error when it can't find a primary key property in the entity. The effect of that is an empty table and a nice error message in the console. I think it's good enough, but can change the UI if necessary.

I think the code that adds the index to the rows isn't required anymore. Is that right?

gashcrumb commented 8 years ago

@alexkieling sorry, would you mind rebasing this whenever you get a chance?

abkieling commented 8 years ago

No problem. I'll do that tonight.

On Mon, Jun 27, 2016 at 10:24 AM, Stan Lewis notifications@github.com wrote:

@alexkieling https://github.com/alexkieling sorry, would you mind rebasing this whenever you get a chance?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hawtio/hawtio-ui/pull/20#issuecomment-228744059, or mute the thread https://github.com/notifications/unsubscribe/AB0lT-XZka00tyRh81Kw-aOUGqpouH7eks5qP88VgaJpZM4I-ddL .

abkieling commented 8 years ago

Code rebased

gashcrumb commented 8 years ago

Great, thanks @alexkieling!