search

hawtio / hawtio-ui

Hawtio UI widgets for hawtio 2.x see http://ui.hawt.io/
Apache License 2.0
7 stars 6 forks source link

Remove hawtio-slideout directive? #40

Closed gashcrumb closed 6 years ago

gashcrumb commented 8 years ago

I don't think it's used in any hawtio 2.x code anymore, and it tends to have screen layout issues, nor is it responsive. Wonder if it's time to get rid of this one?

gashcrumb commented 8 years ago

Ah, it's used in hawtio-integration in a couple spots:

C:\Source\hawtio-integration\plugins\activemq\html\durableSubscribers.html
C:\Source\hawtio-integration\plugins\camel\html\browseEndpoint.html
C:\Source\hawtio-integration\plugins\camel\html\debug.html
C:\Source\hawtio-integration\plugins\camel\html\traceRoute.html

But would be easy to remove.

abkieling commented 7 years ago

What UI component do you think we could use instead of the hawtio-slideout? Ideally, it would be something available in PatternFly or UI Bootstrap.

abkieling commented 7 years ago

We could replace the slide component with a modal. What do you think?

gashcrumb commented 7 years ago

hmm, it'd be a big modal potentially, I think some pages that use the slideout are like the camel debugger which has a table in there etc.

That being said in these cases a controller could maybe use a tab, or expander thingie or any number of other approaches to managing it's content. Or a modal if it's suitable :-)

abkieling commented 7 years ago

I'm changing the Camel plugin - Browse endpoint message to a modal and it's looking good. I agree that the camel debugger might not work well with a modal. We could try to simulate a debug panel similar to the ones we have on IDEs.