Fix https://github.com/hax/refactor/issues/33

hax / refactor

Refactoring support in Atom.

https://atom.io/packages/refactor

MIT License

36 stars 8 forks source link

Closed IceOnFire closed 7 years ago

IceOnFire commented 7 years ago

This should get rid of the annoying error message.

kutsan commented 7 years ago

Thank you!

IceOnFire commented 7 years ago

Thanks to @zaaack for the fix, I only applied it! @hax, could you please accept my PR?

kutsan commented 7 years ago

Sadly, I am not a maintainer. I wanted to say thanks because that dialog was annoying.

Also, thanks @zaaack 👍

iamchenxin commented 7 years ago

Hope this PR will be accepted sooner.

IceOnFire commented 7 years ago

Let's hope that @hax is ok, I'm starting to worry!

For those who need a quick and dirty solution, open your $HOME/.atom/packages/refactor/lib/watcher.coffee and in line 54 replace

@ripper.dispose()

with

@ripper.dispose?()

by just adding a ?.

iamchenxin commented 7 years ago

... 囧, seems, @hax is participating in a party zhihu lives for some days. Hope he will be back soon. @IceOnFire He is ok ...

IceOnFire commented 7 years ago

Welcome back, and thanks for the merge! (^.^)

hax commented 7 years ago

Thank you guys :) The new version has been published.