haxball / haxball-issues

115 stars 43 forks source link

Multiple ball kicks in one game frame abusing #1975

Open punisherhaxball opened 1 year ago

punisherhaxball commented 1 year ago

Example replay

Some players are using external tools or modifications to abuse this bug. They are sending multiple ball kick events inside one game frame and this is causing an unfair advantage in many positions even their shots and other stuff giving them different advantages.

If you don't understand what I mean, just open the example replay and make replay speed 0.5x and wait for the player to kick the ball. In his first kick everything is normal, but when it comes to the second kick, you will see and hear something interesting. He is kicking ball one time? at the second kick, but the game produces ball kick sound two times and not only that ball goes with full momentum and speed.

Oh, and just a note, me and a friend inspected the replay file to check all the frames, events and other stuff. It's 100% confirmed that suspect is sending multiple inputs in one frame in that replay.

Wondering your thoughts about that situation and what are the odds to fix it?

punisherhaxball commented 1 year ago

If the replay doesn't produce sound at all, restart from beginning. Because for me it doesn't by default.

basro commented 1 year ago

This is an old problem, the last attempt at addressing it was this feature:

https://github.com/haxball/haxball-issues/wiki/Headless-Host#setkickratelimit

https://github.com/haxball/haxball-issues/wiki/Chat-Commands#kick_ratelimit-min-rate-burst

The default minimum time between two kick events is 2 frames so it doesn't matter much if they are pressing the kick key more rapidly than that.

punisherhaxball commented 1 year ago

In leagues /kick_ratelimit 6 12 4 is being used for years. So should we switch to different one or what? I see same player doing it even 6 12 4 is on so I have no idea.