haxball / haxball-issues

115 stars 43 forks source link

Room disappears after a certain time #652

Closed ghost closed 5 years ago

ghost commented 5 years ago

I'm hosting a couple of rooms for quite a while and I usually don't need to restart them. But since some days, the rooms disappear after a certain time from the list and if you try to join them using the link you get a Connection closed (4001) error. I haven't touched the script for at least a month and I encounter this error on different machines from different hosters but there is no error message in the console.

PiotrLew commented 5 years ago

hey, I have the same! since morning was throwing out the room 4 times. not just mine, all vps. room for api stands but he is thrown out by haxball. HELP ! Crash often occurs and throws out the whole haxball. you can see it on the menu because is written 10 rooms , 100 people before it was 1000 people 70 rooms. FIX THIS

basro commented 5 years ago

@evi1a: How frequently does this happen? Since how many days ago did the problem start?

I haven't changed anything recently regarding the room list and there is no explicit time limit for how long a room can be up.

@PiotrLew that can happen but rooms should in theory reappear after a while, if they don't it might be a bug.

ghost commented 5 years ago

Sometimes it stays longer, sometimes less but it crashes within a day. Most of the times it's a couple of hours, but it also happened in less than an hour already. I would say since 2-3 days.

If you haven't changed anything at that part, it's weird that it doesn't show any WebRTC related error or actually any error in the room when that happens.

basro commented 5 years ago

Does the recaptcha dialog appear/reset when this happens?

It is indeed looking like a bug, I'll be trying to reproduce it.

ghost commented 5 years ago

I can't tell because of headless. Maybe Piotr can help there or I'll try to reproduce it on my local machine. But maybe it involves activity so Idk

NiExTy commented 5 years ago

I reported exact same problem 3 weeks ago #633.

My last room stayed up for a 5 days before I had to restart it. It is real burden to look for room, and when it will go down the list.

Does the recaptcha dialog appear/reset when this happens?

Not for me. Also I used tokens (if that matters).

I have theory what might be happening.

Sometimes Haxball goes down and throws Cloudflare errors for a while. Which can cause headless to lose connection (?). Haxball thinks connection closed, token expires. Room can't reappear anymore.

Can it be like that? If yes, then extend token expirity to like 1 hour, which should be enough.

basro commented 5 years ago

@NiExTy, I apologize for taking this long to take action. I've been busy lately and I didn't understand how wide spread this issue was so I didn't give it priority.

Sometimes Haxball goes down and throws Cloudflare errors for a while. Which can cause headless to lose connection (?). Haxball thinks connection closed, token expires. Room can't reappear anymore.

Yes, this is along the lines of what I think is happening. But if the room credentials expired the recaptcha dialog should appear, if it doesn't then it's likely a bug in the room reconnect logic.

PiotrLew commented 5 years ago

the problem appears every Friday evening. later it was normal for a month. since yesterday, no room has been standing longer than an hour. How can we fix it? Give you a picture of my console that pops up?

basro commented 5 years ago

I'm looking into it, for now have patience while I figure it out.

PiotrLew commented 5 years ago

http://prntscr.com/lvne2y he does it again. I noticed that it crashes every vps and some ordinary rooms. I hope that this information will help with something

basro commented 5 years ago

Has anyone experienced this problem with unlisted/private rooms?

PiotrLew commented 5 years ago

some private rooms they also do not work

Gorillaz2-D commented 5 years ago

The problem started yesterday in my room, it has an automatic password when it gets 19/25. There is no error message on the console.

jvschiavo commented 5 years ago

I also have this problem.

Sometimes Haxball goes down and throws Cloudflare errors for a while. Which can cause headless to lose connection (?). Haxball thinks connection closed, token expires. Room can't reappear anymore.

Yes, this is along the lines of what I think is happening. But if the room credentials expired the recaptcha dialog should appear, if it doesn't then it's likely a bug in the room reconnect logic.

I don't use tokens and the recaptcha dialog doesn't reappear for me.

ghost commented 5 years ago

Okay, now one room crashed finally :laughing: and the reCaptcha appeared.

basro commented 5 years ago

I have now been able to reproduce this bug, I have some ideas of why it might be happening...

basro commented 5 years ago

I believe I've found the problem, there was a subtle bug in the room list server. The server has been updated with a fix and the bug should hopefully stop happening now.

No action needs to be taken by the room hosts so there's no need to refresh/restart for the fix to apply to your room.

Since the bug is pretty hard to reproduce I'm not 100% certain that the problem is fixed, so please keep an eye out for it and tell me if it continues to happen. If no one reports any problems for a few days I'll consider it fixed and close this issue.

Gorillaz2-D commented 5 years ago

Thanks, basro. My room reappeared, so far no problems.

ghost commented 5 years ago

Thank you. So far no crash, I'll post here if it happens again.

meisterrr commented 5 years ago

Now the other bug, room isn't disappears but its unnable to join to it after certain time, i created new post. #656

basro commented 5 years ago

I believe the fix worked so I'm closing this issue.

joqnez46 commented 11 months ago

still having the problem

np-stacks commented 5 months ago

The problem is reappearing