Improvements of react-native externs.

haxe-react / react-native

React Native externs for Haxe

61 stars 9 forks source link

Closed kiroukou closed 5 years ago

kiroukou commented 5 years ago

The following pull-request incluses mainly :

removal of the Quick Enums dependency. We now are real abstract enums, no dependencies. That improves the completion server in the same time.
Updated externs with some news fields
Addition of "android" and "ios" conditional variables to better typesafety.

Would also make react-next repo the default one, since react isn't very active at the moment (or could be specify both?)

kevinresol commented 5 years ago

This particular NativeEvent is only relevant to PanResponder and I don't think it should deserve a individual module

kiroukou commented 5 years ago

I'd agree but if I remember well, I decided to split it at a time to get a better completion or "go to file definition" feature support in the IDE.

If that's blocking for you, I'll change that.

kevinresol commented 5 years ago

Or rename it to something like PanResponderNativeEvent?

kevinresol commented 5 years ago

I mostly use this library with coconut, which depends on react-next as well. So I think I like the idea of using react-next.

kiroukou commented 5 years ago

Or rename it to something like PanResponderNativeEvent?

Even better ;)

And good news concerning react-next !

Would you like me to correct the PR ?

kevinresol commented 5 years ago

Looks good to me. For smaller stuff I think you can commit directly

kiroukou commented 5 years ago

Ok perfect.