haxetink / tink_await

Haxe async/await
MIT License
58 stars 15 forks source link

Issue with interface #15

Open lerzeel opened 7 years ago

lerzeel commented 7 years ago

Is it possible to use @await and @async on interfaces? The documentation says interfaces are supported but when I try to compile the following interface I get an error message:

@await interface RandomItemInput2
{
    @async function readPart(): String;
}

The error message is:

D:\haxe\haxe-3.3.0-rc2\lib\tink_await/0,1,7/src/tink/await/AsyncField.hx:34: characters 16-24 : Invalid field access : pos D:\haxe\haxe-3.3.0-rc2\lib\tink_await/0,1,7/src/tink/await/Await.hx:63: characters 18-35 : Called from D:\haxe\haxe-3.3.0-rc2\lib\tink_await/0,1,7/src/tink/await/Await.hx:80: characters 35-82 : Called from D:\haxe\haxe-3.3.0-rc2\lib\tink_await/0,1,7/src/tink/await/Await.hx:47: characters 3-24 : Called from D:\haxe\haxe-3.3.0-rc2\lib\tink_await/0,1,7/src/tink/await/Await.hx:37: characters 5-15 : Called from D:\haxe\haxe-3.3.0-rc2\lib\tink_syntaxhub/0,3,6/src/tink/SyntaxHub.hx:43: characters 22-37 : Called from ?:1: characters 2-7 : Called from Aborted

A quick look at the source code reveals that the members of the interface are being processed. But when the "readPart" function is processed the func.expr value is null. This causes the "expr.pos.makeBlankType()" expression to fail.

Any idea what is causing this problem?

kevinresol commented 7 years ago

I think a quick fix is to not put the meta in the interface, but in the implementation.

So make your interface like this:

interface RandomItemInput2
{
    function readPart():Surprise<String, Dynamic>;
}

and implementation:

@await class Input implements RandomItemInput2
{
    @async public function readPart():String { /* ... */ }

}

But it still worth a look about the bug itself, or maybe we should just amend the readme.

lerzeel commented 7 years ago

Great tip! This seems to solve the problem.

In case someone is trying to find the right import, here it is: import tink.core.Future.Surprise;

kevinresol commented 7 years ago

using tink.CoreApi; is the recommended way to import everything from tink_core :smile:

kevinresol commented 7 years ago

btw let's keep this open until we fix the readme or something