search

haxetink / tink_core

Core utilities
https://haxetink.github.io/tink_core
MIT License
117 stars 33 forks source link

Disable Promise.cache() in java #85

Closed kLabz closed 6 years ago

kLabz commented 6 years ago

80 broke java target even when we do not explicitly use Promise.cache().

Seems like that didn't disturb you too much when you found out java didn't like it :D But it breaks things, like buddy.

Everything works fine when surrounding cache by #if !java. Maybe there is a fix for making it work with java, but I have no idea atm.

Sorry about the whitespace diff, there was mixed line endings =/ You can see the "real" diff here

back2dos commented 6 years ago

Sorry, I decided to replicate the change to not lose blameability.

Generally speaking, I strictly advise against using hxjava in its current state ;)

kLabz commented 6 years ago

No problem :) I think you didn't replicate the second commit (disabling the tests), though.

I don't use it, but this broke buddy tests and I was making a PR to buddy :)

back2dos commented 6 years ago

Ah :D