search

haxetink / tink_macro

The macro toolkit
MIT License
57 stars 17 forks source link

don't use neko.Lib.rethrow when not in neko #15

Closed Simn closed 7 years ago

Simn commented 7 years ago

Sorry about the whitespaces...

This calls neko.Lib.rethrow only if it's actually running in neko.

back2dos commented 7 years ago

@Simn There's actually Error.rethrow which does the platform dance. I wonder what happened to the "detect throw in catch and generate rethrow" idea that I vaguely remember having read somewhere at some time?

Simn commented 7 years ago

People (or well, Nicolas) were arguing that you might not want to automatically re-throw an exception. There was also some other problem that I don't recall right now.

back2dos commented 7 years ago

Ok, fair enough. Thanks for the info ;)