search

haxetink / tink_sql

SQL embedded into Haxe
MIT License
53 stars 17 forks source link

Fixes #123 #124

Closed kevinresol closed 3 years ago

kevinresol commented 3 years ago

I am not sure how to create the ExprType for the Field (currently I stubbed a VBool there). Do we already have a haxe.macro.Type->ExprOf<ExprType> utility function?

kevinresol commented 3 years ago

I thought I can get the ExprType from the query itself with VTypeOf(query.fields.$fname) but query.fields seems to hold the raw fields before selection so the compiler complains Table2_Fields has no field maxId

So I would like to confirm if Selected#fields are the fields available for selection (input fields) or the selected fields (output fields)?

https://github.com/haxetink/tink_sql/blob/9922d2d10d12e0cbd941d2235e69078db4eb2b3e/src/tink/sql/Dataset.hx#L82

kevinresol commented 3 years ago

Seems working with the tests. Merging now.