random cleanups in AutoObservable.hx

haxetink / tink_state

Handle those pesky states.

The Unlicense

29 stars 13 forks source link

random cleanups in AutoObservable.hx #54

Closed nadako closed 3 years ago

nadako commented 3 years ago

remove unused optional Noise argument (what was that?)
use haxe 4 function type

nadako commented 3 years ago

Hmm, okay I didn't run the tests and broke something... Looks like this Noise argument was needed for something after all? Maybe proper type selection or something?

back2dos commented 3 years ago

Looks like this Noise argument was needed for something after all? Maybe proper type selection or something?

Yeah, currently top down inference looks at the underlying type, because reasons: https://github.com/HaxeFoundation/haxe/issues/3525

IIRC that makes Observable.auto(last -> ...) infer last to be Unknown->Void, which then fails to actually match an available cast.