search

haxetink / tink_tcp

TCP everywhere!
MIT License
13 stars 6 forks source link

StdAcceptor, Concurrency Issues #13

Open piboistudios opened 4 years ago

piboistudios commented 4 years ago

The proposed changes add a StdAcceptor and adjust the internal tink.tcp.Connection.SocketInput in order to resolve the Socket.select issue.

Changes conditionals to allow an sys target to utilize the tink.tcp.Server class.

kevinresol commented 4 years ago

Would be nice if you can revert all the formatting changes (indentation, newlines, whitespace and whatnot). It is a bit hard to review now because it is difficult to tell what are the actual changes.

piboistudios commented 4 years ago

@kevinresol Can you point out an example commit where the whitespace is still an issue? I thought I removed (most) of the whitespace alterations.

kevinresol commented 4 years ago

I just see them in the "changes" tab of this PR