search

haxetink / tink_web

Tinkerbell Web Framework
https://haxetink.github.io/tink_web
43 stars 14 forks source link

Scheme and the colon #119

Closed kevinresol closed 3 years ago

kevinresol commented 3 years ago

So: {scheme: 'http:'} works but {scheme: 'http'} doesn't.

I guess we should detect that and auto add it.

back2dos commented 3 years ago

Uhm, I'm slightly confused. Is it not added here or are you referring to something else?

kevinresol commented 3 years ago

oops, because I did this:

var endpoint:RemoteEndpoint = {
    host: new Host(config.host, config.port),
    scheme: config.scheme,
    path: config.path
        .split('/')
        .filter(v -> v != '')
        .map(Portion.new)
    ,
}
back2dos commented 3 years ago

Totally missed the implicit cast. Should work fine now ;)