haxeui / haxeui-core

The core library of the HaxeUI framework
http://haxeui.org
MIT License
346 stars 72 forks source link

project doesn't compile, there's an inheritance\naming problem between invalidate func of Displayobject and Component #223

Closed Helgiii closed 6 years ago

Helgiii commented 6 years ago

C:\HaxeToolkit\haxe\lib\haxeui-core\git\haxe\ui\core\Component.hx:2113: chars 11-71 : Error: Field invalidate should be declared with 'override' since it is inherited from superclass haxe.ui.backend.ComponentBase C:\HaxeToolkit\haxe\lib\haxeui-core\git\haxe\ui\core\Component.hx:2113: chars 11-71 : Error: Field invalidate overloads parent class with different or incomplete type C:\HaxeToolkit\haxe\lib\haxeui-core\git\haxe\ui\core\Component.hx:2113: chars 11-71 : Error: Different number of function arguments

I used: haxelib git haxeui-core https://github.com/haxeui/haxeui-core so in cases like this what should I do? there are no tags or fixed releases so I can't rollback.. thanx

ianharrigan commented 6 years ago

Hmmm, is this openfl 8? Thats kinda annoying, i guess we could rename all "invalidate" functions to "invalidateComponent" :(

Helgiii commented 6 years ago

yep openfl 8. great!

intoxopox commented 6 years ago

See https://github.com/haxeui/haxeui-openfl/issues/24

ianharrigan commented 6 years ago

Ok, this should be fixed now. Can you retest and close if thats the case please?

Cheers, Ian

Helgiii commented 6 years ago

I learned to use .current files to switch to older versions, and can continue work on my project ;)

as for the latest updates, just tried again and get this compile time error C:/HaxeToolkit/haxe/lib/haxeui-core/0,0,4/haxe/ui/Toolkit.hx:3: characters 7-37 : Type not found : haxe.ui.backend.ToolkitOptions

ianharrigan commented 6 years ago

really??? Did you update everything?

Helgiii commented 6 years ago

yep, haxelib update (no git versions used) and the file haxe.ui.backend.ToolkitOptions is missing I searched the whole haxe\lib folder with ... search tool

ianharrigan commented 6 years ago

can you do a haxelib list and paste results here? Its very strange as ToolkitOptions was introduced quite a while ago

Helgiii commented 6 years ago

C:\Users\Admin>haxelib list actuate: [1.8.7] as3hx: [1.0.6] box2d: [1.2.3] flixel: 4.3.0 [4.4.1] haxeui-core: 0.0.1 0.0.3 [0.0.4] haxeui-openfl: 0.0.1 [0.0.2] hscript: 2.1.1 [2.2.0] hxcpp: [3.4.188] layout: [1.2.1] lime-samples: 4.0.1 [6.2.0] lime: 2.9.1 5.8.2 5.9.1 6.0.1 [6.3.0] openfl-samples: [6.0.0] openfl: 3.6.1 6.5.0 6.5.1 6.5.3 7.0.0 [8.0.1]

intoxopox commented 6 years ago

I'm not having the ToolKitOptions issue and new invalidateComponent methods work as expected. So this issue is closed for me. Perhaps it should be noted that I removed all of haxeui-core and haxeui-openfl via haxelib before running install again, so mine was a clean install.

Helgiii commented 6 years ago

intoxopox , thanx) removed all libs, installed them back compiles just fine)))