search

haxeui / haxeui-core

The core library of the HaxeUI framework
http://haxeui.org
MIT License
347 stars 71 forks source link

Email Validator only accepts 2-3 letter TLDs. #516

Closed Benjie56 closed 1 month ago

Benjie56 commented 1 year ago

The email validator regex only accepts 2 and 3 character top-level-domains. The current longest TLD is .vermögensberatung (XN--VERMGENSBERATUNG-PWB), which is 24 characters long. The longest possible is 63 characters long. I personally use a .scot email address, which gets rejected by email fields.

ianharrigan commented 1 year ago

fair point - i just grabbed the regex online somewhere.

Tezar commented 1 month ago

Could try to fix that.

Two approaches:

  1. either relax the pattern to allow for vermögensberatung and friends
  2. add (and occasionally update) 10 KiB official domain list

Any preference @ianharrigan ?

ianharrigan commented 1 month ago

my personal preference would be the former, ie, relax the regexp - i just dont like the idea of adding some 10kb file and then having to remember to update it, etc... feels like additional maintenance... ... ... ?