haxeui / haxeui-flixel

The Flixel backend of the HaxeUI framework
MIT License
48 stars 15 forks source link

Buttons are wonky - no right edge, no bottom edge, problems with onhover and onclick #20

Closed greysondn closed 4 years ago

greysondn commented 4 years ago

Again, one I've written up the text for so I'll just paste it here.

In my repo: 04-buttonsborked Specific commit: 41e19b9 Zipped version attached to this issue: 04-buttonsborked.zip


I've noticed that buttons don't have a right edge anymore, and some buttons go kinda wonky when you hover over them. This project exists to collect those and any other button-based issues I find in one place.

The top two buttons have no right edge and go completely square if you hover them.

The bottom two buttons go wonky if you hover them.

There may be others; this however is probably a solid start.

haxelib versions...

flixel, git 4d23ed84
haxeui-core, haxelib 1.0.7
haxeui-flixel, git 110fd2ac

Test targets

air      - not tested
android  - not tested
electron - not tested
flash    - not tested
html5    - Has this bug.
hashlink - not tested
neko     - not tested
windows  - not tested

Screenshots:

Right edge missing - image

Bottom edge missing - image

Onhover issues - image

Onclick issues - image

ianharrigan commented 4 years ago

Ive tested this locally and done seem to have the same issues, all looks fine. From your version list it looks like the only difference between us might be flixel itself.

Can you downgrade to 4.6.1 and if this still happens?

Cheers, Ian

lime: 7.2.1 7.3.0 7.5.0 7.6.1 7.6.2 [7.6.3]
openfl: 6.2.0 8.0.0 8.1.0 8.8.0 8.9.0 8.9.1 8.9.2 8.9.3 8.9.4 8.9.5 [git]
flixel: 4.6.0 [4.6.1]
haxeui-core: 0.0.4 1.0.4 1.0.6 [dev:C:\Work\HaxeUI\haxeui-core]
haxeui-flixel: [dev:C:\Work\HaxeUI\backends\haxeui-flixel]

hxcpp (windows): image

html5: image

greysondn commented 4 years ago

Ian: After setting Flixel to 4.6.1 - image

Exhaustive haxelib:

dox: 1.1.0 [1.2.0]
flixel-addons: 2.7.1 2.7.3 [2.7.5]
flixel-templates: 2.5.3 2.5.4 2.5.5 2.6.2 [2.6.3]
flixel-tools: 1.4.2 1.4.3 [1.4.4]
flixel-ui: 2.3.1 [2.3.2]
flixel: 4.5.1 4.6.0 [4.6.1] git
formatter: 1.5.1 1.6.0 1.8.1 [1.9.1]
haxeui-core: [1.0.7] git old
haxeui-flixel: 0.0.0 [git]
hscript: [2.3.0]
hxcpp-debug-server: [dev:c:\Users\Dorian Greyson\.vscode\extensions\vshaxe.hxcpp-debugger-1.2.4\hxcpp-debug-server]
hxcpp: 4.0.4 4.0.8 4.0.19 4.0.52 [4.0.64]
lime: 7.2.0 7.2.1 7.3.0 7.5.0 7.6.1 [7.6.3]
openfl-tools: [1.0.10]
openfl: 8.7.0 8.8.0 8.9.1 8.9.3 [8.9.5]
yaml: 1.3.0 [fix-your-lib] git

Not a clue. Project config only includes:

<haxelib name="flixel" />
<haxelib name="haxeui-core" />
<haxelib name="haxeui-flixel" />

Edit: I removed about half my haxelibs and did a clean on the project... the libs were unrelated, and the problem persists. But at least that should make that list easier to read now and in the future.


Edit2: Currently poking and prodding. Maybe we're lucky and I'm an idiot. Still in process of testing.

C:\WINDOWS\system32>haxelib update
Checking dox
Checking flixel
flixel was updated
Checking flixel-addons
Checking flixel-templates
Checking flixel-tools
Checking flixel-ui
Checking formatter
Checking haxeui-core
haxeui-core was updated
Checking haxeui-flixel
haxeui-flixel was updated
Checking hscript
Checking hxcpp
Checking hxcpp-debug-server
Failed with error: No such Project : hxcpp-debug-server
Checking lime
Checking openfl
Checking openfl-tools
Checking yaml
yaml was updated
Done

Edit 3: No love there. You're running a git version of openfl; now trying that.

greysondn commented 4 years ago

Deliberate double comment. It's OpenFL. That's the missing dependency here.

image

Kick it back to 8.9.5 and it breaks. Kick it forwards to git ae6f1401b433 and it works correctly. Later commits will likely work fine; that's their current develop branch commit as of this writing.

If there's nothing you need from me, it appears this can be closed. At least on the face of it.

ianharrigan commented 4 years ago

OK, great - ill close this then

Cheers, Ian