search

haxeui / haxeui-heaps

MIT License
31 stars 12 forks source link

fix hxd.res.Image.ImageInfo being used instead of haxe.ui.assets.ImageInfo #18

Closed ZwodahS closed 3 years ago

ZwodahS commented 3 years ago

ImageInfo added to heaps recently in heaps (49fe167e3) inside hxd.res.Image. Moving the import to the start of file instead to allow haxe.ui.assets.ImageInfo to be used instead.

ianharrigan commented 3 years ago

Is this PR complete? I only see these diffs:

image

I have version locally that fixes this, but it looks more like this:

image

ZwodahS commented 3 years ago

On my local copy, just moving it up to the top works, since importing hxd.res.Image.ImageInfo was a side effect of importing hxd.res.Image and we have no use for it in the file (as far as I can see). By moving it up, the ImageInfo get reimported as haxe.ui.assets.ImageInfo

Your solution works too, either one is fine I think, just depending on which one is preferred for the repo.

ianharrigan commented 3 years ago

OK, cool - thanks for this - ive actually done it "the other" way now, as it means that its not dependent on order... which might be a bit of a gotcha - probably not, it would be fairly obvious, but at least this way we never have to think about it again :)

Thanks for the PR!

Cheers, Ian